Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] mailmap: avoid out-of-bounds memory access

From: Romain Francoise <hidden>
Date: 2016-06-15 22:55:08

Jeff King [off-list ref] writes:
So you could also check for "left == nstart" before the loop even
begins. I think your fix (to just make the loop more robust to that
precondition) is better, though, as the rest of the code does the right
thing with such a value of nend.
Yep.
It looks like t4203 triggers this problem. Curious that valgrind does
not find it. I guess since it does not have compiler support, it cannot
find out-of-bound errors on stack buffers. Does the rest of the test
suite turn up clean with AddressSanitizer?
I tested your 'master' and your 'pu' with expensive tests enabled and both
are clean after fixing t4203.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help