Re: [PATCH] Fixes handling of --reference argument.
flat view
From: Jeff King <hidden>
Date: 2016-06-15 22:55:06
On Wed, Oct 24, 2012 at 09:52:52PM -0700, szager@google.com wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Stefan Zager <redacted> --- git-submodule.sh | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/git-submodule.sh b/git-submodule.sh index ab6b110..dcceb43 100755 --- a/git-submodule.sh +++ b/git-submodule.sh@@ -270,7 +270,6 @@ cmd_add() ;; --reference=*) reference="$1" - shift ;;
Is that right? We'll unconditionally do a "shift" at the end of the loop. If it were a two-part argument like "--reference foo", the extra shift would make sense, but for "--reference=*", no extra shift should be neccessary. Am I missing something? -Peff