Thread (19 messages) flat view 19 messages, 4 authors, 2016-06-15
DORMANTno replies

[PATCH 4/8] git-config: remove memory leak of key regexp

From: Jeff King <hidden>
Date: 2016-06-15 22:55:06
Subsystem: the rest · Maintainer: Linus Torvalds

This is only called once per invocation, so it's not a major
leak, but it's easy to fix.

Signed-off-by: Jeff King <redacted>
---
 builtin/config.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/builtin/config.c b/builtin/config.c
index e1c33e0..e660d48 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -248,6 +248,10 @@ static int get_value(const char *key_, const char *regex_)
 		git_config_from_file(fn, system_wide, data);
 
 	free(key);
+	if (key_regexp) {
+		regfree(key_regexp);
+		free(key_regexp);
+	}
 	if (regexp) {
 		regfree(regexp);
 		free(regexp);
-- 
1.8.0.3.g3456896
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help