Re: Fix potential hang in https handshake.

Stefan Zager [off-list ref] writes:

On Oct 19, 2012 7:11 AM, "Shawn Pearce" [off-list ref] wrote:

quoted

The issue with the current code is sometimes when libcurl is opening a
CONNECT style connection through an HTTP proxy it returns a crazy high
timeout (>240 seconds) and no fds. In this case Git waits forever.
Stefan observed that using a timeout of 50 ms in this situation to
poll libcurl is better, as it figures out a lot more quickly that it
is connected to the proxy and can issue the request.

Correct.  Anecdotally, the zero-file-descriptor situation happens only once
per process invocation, so the risk of passing a too-long timeout to
select() is small.

Thanks.