Re: [PATCH] git-cvsimport: allow author-specific timezones

Jeff King [off-list ref] writes:

On Mon, Oct 15, 2012 at 08:50:21PM -0700, Junio C Hamano wrote:

quoted

Chris Rorvick [off-list ref] writes:

quoted

It occurred to me that the success of the unit test depends on the
host platform's zoneinfo database.  I think this problem is inherent
with this functionality.  Should the unit test attempt to detect
support for the used timezones and short circuit if this fails?  Not
sure exactly how I'd do this, but wondering if it's worth thinking
about.

Yeah, that did indeed cross my mind.

You could say TZ=QST6QDT or something silly like that but that in
turn has to assume your tzset() is POSIX.1 compliant anyway.

We use EST5 in t0006 (it was originally just "EST" but IRIX complained).
It's been in the test suite for two years without a problem, so it may
be simple and safe enough to just use that.

Sounds good.  As the test vector for the last piece seems to be
designed to show that the dst conversion correctly works, we would
need to use STD$nDST formats, though.