Re: [PATCH v4 00/12] Wildmatch v4
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:00
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH v4 00/12] Wildmatch v4 · Torsten Bögershausen <hidden>
- 2016-06-15 · Re: [PATCH v4 00/12] Wildmatch v4 · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH v4 00/12] Wildmatch v4 · Torsten Bögershausen <hidden>
- 2016-06-15 · Re: [PATCH v4 00/12] Wildmatch v4 · Nguyen Thai Ngoc Duy <hidden>
- 2016-06-15 · [PATCH v4 00/12] Wildmatch v4 · Nguyễn Thái Ngọc Duy <hidden>
Junio C Hamano [off-list ref] writes:
quoted hunk ↗ jump to hunk
Ahh, it must be this bits from t/test-lib.sh t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git i/t/test-lib.sh w/t/test-lib.sh index 514282c..489bc80 100644 --- i/t/test-lib.sh +++ w/t/test-lib.sh@@ -230,7 +230,7 @@ else say_color() { test -z "$1" && test -n "$quiet" && return shift - echo "$*" + printf "%s\n" "$*" } fi
I'll queue this fix separately before your series on 'pu'. -- >8 -- Subject: [PATCH] test-lib: Fix say_color () not to interpret \a\b\c in the message When running with color disabled (e.g. under prove to produce TAP output), say_color() helper function is defined to use echo to show the message. With a message that ends with "\c", echo is allowed to interpret it as "Do not end the line with LF". Use printf "%s\n" to emit the message literally. Signed-off-by: Junio C Hamano <redacted> --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index c0d04c4..280b3aa 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh@@ -169,7 +169,7 @@ else say_color() { test -z "$1" && test -n "$quiet" && return shift - echo "$*" + printf "%s\n" "$*" } fi
--
1.8.0.rc1.82.ga68bb49