Re: [Patch v2 5/8] Prerequisites for creating nice html for all files in Documentation/howto
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:00
Thomas Ackermann [off-list ref] writes:
quoted
From 2b9538990e30ae0911117c8e3d8b6891c9de31cf Mon Sep 17 00:00:00 2001From: Thomas Ackermann <redacted> Date: Sat, 29 Sep 2012 17:28:54 +0200 Subject: [PATCH] Prerequisites for creating nice html for all files in Documentation/howto
These four lines are not needed; please remove them from all the patches.
quoted hunk
@@ -149,13 +152,13 @@ then info "Found matching head pattern: '$head_pattern'" for group_pattern in $group_patterns; do - for groupname in $groups; do - info "Checking group: '$groupname' against pattern: '$group_pattern'" - matchlen=$(expr "$groupname" : "$group_pattern") - if test "$matchlen" = "${#groupname}" - then - grant "Allowing group: '$groupname' with pattern: '$group_pattern'" - fi + for groupname in $groups; do + info "Checking group: '$groupname' against pattern: '$group_pattern'" + matchlen=$(expr "$groupname" : "$group_pattern") + if test "$matchlen" = "${#groupname}" + then + grant "Allowing group: '$groupname' with pattern: '$group_pattern'" + fi done done
The inner "done" does not seem to align with the "for ...; do" it corresponds to, does it?