Thread (1 message) 1 message, 1 author, 2016-06-15

Re: push.default documented in "man git-push"?

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:59

Matthieu Moy [off-list ref] writes:
Nguyen Thai Ngoc Duy [off-list ref] writes:
quoted
On Fri, Oct 05, 2012 at 01:03:28PM -0700, Junio C Hamano wrote:
quoted
OK, the messages are supposed to advise how to turn them off, so we
would want some code updates in that case.
Something like this? It turns out none of the advice messages says
anything about advice.*.
Personally, I'm fine with the current situation. Advanced users can read
the documentation, and for others, the messages are usually more helpful
than annoying.
OK, you convinced me.
I disagree. Having advices turned on doesn't harm anyone. I don't
remember anyone complaining about the verbosity of Git's advices. I've
seen *many* more people complaining about the user-unfriendliness of
Git.

I'm fine with very verbose (and scary) messages when the user did
something wrong (for example, the advice.implicitIdentity is something
you should never see if you configured Git properly before commiting).
But the user should not feel blamed for using the default configuration
of advice messages. The tripple repetition in "git status" shown above
really sounds like "hey, dumb user, why did you not set
advice.statusHints already", and is doubly scary for newbies, because
they are not told how to set the variable, nor what a config variable is
to Git.
Let's let the list of advice.* messages in Documentation/config.txt
do their job.

Nguyen, thanks for taking a look.  I do agree the extra "here is how
to rob helpful hints from yourself before you learn them" seems to
do more harm than good.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help