Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

From: Joachim Schmitz <hidden>
Date: 2016-06-15 22:54:58

Junio C Hamano wrote:
Junio C Hamano [off-list ref] writes:
quoted
Ben Walton [off-list ref] writes:
quoted
Avoid a GNU-ism in the cp options used by t5400-send-pack.  Change
-a
to -pR.

Signed-off-by: Ben Walton <redacted>
---
Thanks, but is "-p" essential for this test to pass, or can we get
away with just "-R"?
Besides, when you spot a potential problem, please ask "git grep"
to catch them all.

   $ git grep "cp -a" t/
   t/t5400-send-pack.sh:   cp -a parent child &&
   t/t5550-http-fetch.sh:  cp -a
   .git"$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
t/t5800-remote-helpers.sh:      cp -a server server2 &&

There's 2 more places in Documentation/git-tutorial.txt. There it looks like 
we'd want to use 'cp -pR' instead

Bye, Jojo 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help