Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 5/6] log: pass rev_info to git_log_config()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:57

Jeff King [off-list ref] writes:
Agreed. Maybe the simplest thing would be to have grep_config fill in a
"static struct grep_opt grep_defaults", and then memcpy that into place
during init_revisions?
Yes, I was doing that for a bit last night, but then realized that
the grep_config() should be split into two (grep specific part and
then the bits that cascade to others, which is "git grep" specific
requirement; it is far better to let other callers to arrange the
cascading themselves) before moving the grep specific bit to the
top-level, so that needs to come first.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help