Re: [PATCH] gitk: refresh the index before running diff-files

Junio C Hamano [off-list ref] writes:

Jeff King [off-list ref] writes:

quoted

On Sat, Sep 29, 2012 at 12:11:58AM +0200, Andreas Schwab wrote:

quoted

Jeff King [off-list ref] writes:

quoted

+proc refresh_index {} {
+    global need_index_refresh
+    if { $need_index_refresh } {
+	exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"

I think the usual idiom for ignoring errors is to use catch around exec,
avoiding the extra shell wrapper:

        catch { exec git update-index --refresh }

Thanks. I don't speak tcl at all, but your version makes much more
sense.

But isn't the redirection still needed?  Otherwise the "Needs
update" messages will go to the terminal, no?

The exec command captures both stdout and stderr and returns it as its
value, and catch ignores it.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."