Thread (28 messages) flat view 28 messages, 3 authors, 2016-06-15

Re: [PATCH 04/21] git p4: fix error message when "describe -s" fails

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:53

Pete Wyckoff [off-list ref] writes:
quoted hunk ↗ jump to hunk
The output was a bit nonsensical, including a bare %d.  Fix it
to make it easier to understand.

Signed-off-by: Pete Wyckoff <redacted>
---
 git-p4.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py
index eef5c94..d7ee4b4 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -2679,7 +2679,8 @@ class P4Sync(Command, P4UserMap):
             if r.has_key('time'):
                 newestTime = int(r['time'])
         if newestTime is None:
-            die("\"describe -s\" on newest change %d did not give a time")
+            die("Output from \"describe -s\" on newest change %d did not give a time" %
+                newestRevision)
Shouldn't it say "p4 describe -s"?
         details["time"] = newestTime
 
         self.updateOptionDict(details)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help