Re: [PATCH] Teach git-completion about git p4

Ryan Cumming [off-list ref] writes:

From: Ryan Cumming <redacted>

git p4 was moved out of contrib in 1.7.11 but it git-completion didn't
know about it. Add git p4 completion based on the existing SVN
completion. It covers all known subcommands and options except for the
-/ option for clone which doesn't use the standard -- prefix.

Signed-off-by: Ryan Cumming <redacted>
---

Sounds sensible; thanks.

+_git_p4 ()
+{
+...
+		local submit_opts="
+			--origin= -M --preserve-user --export-labels
+			$common_opts
+			"
+
+		case "$subcommand,$cur" in
...
+		submit,--*)
+			__gitcomp "$submit_opts"

This is taken when $cur begins with --, but $submit_opts includes
"-M" which doesn't begin with it.  Is that a problem?

+			;;
+		submit,*)
+			__gitcomp "$(__git_refs)"
+			;;
+		esac
+	fi
+}