Re: [PATCH v4 3/6] Color skipped tests blue
From: Jeff King <hidden>
Date: 2016-06-15 22:54:50
On Wed, Sep 19, 2012 at 09:24:23PM +0100, Adam Spiers wrote:
quoted hunk ↗ jump to hunk
t/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/t/test-lib.sh b/t/test-lib.sh index 5293830..78c88c2 100755 --- a/t/test-lib.sh +++ b/t/test-lib.sh@@ -182,13 +182,13 @@ then error) tput bold; tput setaf 1;; # bold red skip) - tput bold; tput setaf 2;; # bold green + tput setaf 4;; # blue warn) tput bold; tput setaf 3;; # bold yellow pass) tput setaf 2;; # green info) - tput setaf 3;; # brown + tput setaf 3;; # yellow/brown
I happened to be running a test script with "-v" earlier today, and I noticed that the "expecting success..." dump of the test contents is also yellow. By your new rules, shouldn't it be blue? I think it is matching the "info" type, which from the discussion should be blue, no? Maybe it is just my terminal. I see it is labeled as "brown" here, but it looks very yellow (and I am using the stock xterm colors. According to: https://en.wikipedia.org/wiki/ANSI_colors It looks it really is brown on some platforms. I'm not sure if it is worth worrying about. I don't really want to get into configurable colors just for the test-suite output. -Peff