Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v7 1/4] make poll available for other platforms lacking it

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:47

"Joachim Schmitz" [off-list ref] writes:
quoted
quoted
@@ -1605,6 +1610,11 @@ ifdef NO_GETTEXT
 	BASIC_CFLAGS += -DNO_GETTEXT
 	USE_GETTEXT_SCHEME ?= fallthrough
 endif
+ifdef NO_POLL
+	NO_SYS_POLL_H = YesPlease
+	COMPAT_CFLAGS += -DNO_POLL -Icompat/poll
+	COMPAT_OBJS += compat/poll/poll.o
+endif
I think my guesses above are correct, so will queue with the trivial
and obvious fixup.
Well I was unde the impression that is <sys/poll.h> isn't
available, there might be a <poll.h> and it that isn't available
either we use compat/.../poll.[ch]. But rethinking your changed
does makes perfect sense.
Heh, my comment was not about names between NO_POLL_H vs NO_POLL.
With the way you wrote the code, the symbols defined for Windows and
MINGW must match what controls the hunk around ll.1610, so what
makes perfect sense to you is indeed your code ;-)
OK, so I guess I'm ready for the 'final touch', my NonStop
specific changes, will post them shortly...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help