Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:47

Michael Haggerty [off-list ref] writes:
But how far should this policy be taken?  It seems to me that strict
adherence to the policy would dictate that *.h files should *never*
include other git project files.
I wouldn't call that a "policy".  It's something we think about when
adding a new "#include" to see if it is worth adding and/or if it is
the right place to add it to reduce code churn.

As I said, what policy to pick and stick to is open to discussion,
and I wanted to leave it outside the scope of this series.  As it
has been cooking in 'next', I do not think it is worth reverting the
inclusion of "string-list.h" to delay this topic.  It is something
that can and should be cleaned up when we decide to pick the
inclusion policy and enforce it.  If we choose to go in the other
direction, we would end up adding it back, so let's keep it as-is
for now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help