Thread (6 messages) flat view 6 messages, 4 authors, 2016-06-15

Re: [PATCH] Makefile: respect $LINGUAS variable on selecting .mo files to install

From: Michael J Gruber <hidden>
Date: 2016-06-15 22:54:45

Nguyễn Thái Ngọc Duy venit, vidit, dixit 14.09.2012 14:40:
quoted hunk ↗ jump to hunk
Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 On Fri, Sep 14, 2012 at 6:35 PM, Nguyen Thai Ngoc Duy [off-list ref] wrote:
 > We should honor LINGUAS variable on installation. Only languages
 > listed in that variable are installed. Many if not most of projects do
 > that already.

 And here is a try.

 Makefile | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index 56301dc..eeba645 100644
--- a/Makefile
+++ b/Makefile
@@ -2437,7 +2437,11 @@ po/git.pot: $(LOCALIZED_C)
 
 pot: po/git.pot
 
+ifdef LINGUAS
+POFILES := $(shell sh -c "ls $(patsubst %,po/%.po,$(LINGUAS)) 2>/dev/null")
+else
 POFILES := $(wildcard po/*.po)
+endif
 MOFILES := $(patsubst po/%.po,po/build/locale/%/LC_MESSAGES/git.mo,$(POFILES))
 
 ifndef NO_GETTEXT
While that may be worthwhile if LINGUAS is some sort of standard I don't
think it relates to the discussion at hand. The problem is not the set
to choose from but the choice and the specificity of the choice (which
parts of the code does it affect).

Michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help