On 07.09.12 23:55, Junio C Hamano wrote:
[Discarded]
* jc/sanitize-nkd-lazy-iconv-open (2012-07-31) 1 commit
. macos: lazily initialize iconv
Teach the code that works around NKD/NKC gotcha on MacOS to call
iconv_open() only when it is necessary, in the hope of avoiding
set-up overhead. It turns out that there was no noticeable
improvements.
My vote is not to discard the branch:
Even if the improvements are not measurable, the lazy iconv_open
is a good coding style.
It might inspire people to use resources carefully,
and only allocate them if they are really needed.