Re: [PATCH 9/9] Add git-check-ignores

On Wed, Sep 5, 2012 at 12:26 AM, Junio C Hamano [off-list ref] wrote:

Nguyen Thai Ngoc Duy [off-list ref] writes:

quoted

quoted

+static void output_exclude(const char *path, struct exclude *exclude)
+{
+       char *type = exclude->to_exclude ? "excluded" : "included";
+       char *bang = exclude->to_exclude ? "" : "!";
+       char *dir  = (exclude->flags & EXC_FLAG_MUSTBEDIR) ? "/" : "";
+       printf(_("%s: %s %s%s%s "), path, type, bang, exclude->pattern, dir);

These English words "excluded" and "included" make the translator me
want to translate them. But they could be the markers for scripts, so
they may not be translated. How about using non alphanumeric letters
instead?

I agree they should not be translated, but it is a disease to think
unintelligible mnemonic is a better input format for scripts than
the spelled out words.  "excluded/included" pair is just fine.

Not all mnemonic is unintelligible though. "+" and "-" may fit well in
this case. I'm just trying to make sure we have checked the mnemonic
pool before ending up with excluded/included.
-- 
Duy