RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

From: Junio C Hamano [mailto:gitster@pobox.com]
Sent: Tuesday, September 04, 2012 8:47 PM
To: Joachim Schmitz
Cc: git@vger.kernel.org; 'Johannes Sixt'
Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

Junio C Hamano [off-list ref] writes:

quoted

"Joachim Schmitz" [off-list ref] writes:

quoted

quoted

Only with the observation of "clone", I cannot tell if your timer is
working.  You can try repacking the test repository you created by
your earlier "git clone" with "git repack -a -d -f" and see what
happens.

It does update the counter too.

Yeah, that was not a very good way to diagnose it.

You see the progress from pack-objects (which is the underlying
machinery "git repack" uses) only because it knows how many objects
it is going to pack, and it updates the progress meter for every
per-cent progress it makes, without any help from the timer
interrupt.

I think the "Counting objects: $number" phase is purely driven by
the timer, as there is no way to say "we are done X per-cent so
far".

Doesn't your repack show "Counting objects: " with a number once,
pause forever and then show "Counting objects: $number, done."?

Yes, only once, when it is done
$ ./git repack -a -d -f
warning: no threads support, ignoring --threads
Counting objects: 140302, done.
Compressing objects:   1% (1385/138407)