Thread (11 messages) flat view 11 messages, 2 authors, 2016-06-15

Re: [PATCH v2] test: set the realpath of CWD as TRASH_DIRECTORY

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:36

Possibly related (same subject, not in this thread)

Michael Haggerty [off-list ref] writes:
By the way, is the use of realpath(3) permissible in git code?
GIT_CEILING_DIRECTORIES handling could be fixed relatively easily by
using this function to canonicalize pathnames before comparison.
As long as we can add a compat/realpath.c (perhaps lift one from
glibc before they went GPLv3) for platforms that matter, I do not
see it as a huge problem.  How close is abspath.c::real_path() to
what you need?
[1] This would be analogous to the inclusion of a space in "trash
directory.*", which I presume was done to detect space-handling problems
quickly.
Yeah, understood where you are coming from, and I think I can agree
with where you are trying to go.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help