Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

I think git show is broken

From: Matthew Caron <hidden>
Date: 2016-06-15 22:54:35
Subsystem: the rest · Maintainer: Linus Torvalds

(otherwise, there was a very strange change made to its functionality, 
which the documentation does not reflect)


Old, working git:

===
$ git --version
git version 1.7.0.4
$ git show --quiet --abbrev-commit --pretty=oneline 
47a7aee54553fb718c376cfa9d7de4389a391e33
47a7aee Fix hyperlinks for dependent tickets (#7139, #4976).
===

New, "broken" git:

===
$ git --version
git version 1.7.9.5

$ git show --quiet --abbrev-commit --pretty=oneline 
47a7aee54553fb718c376cfa9d7de4389a391e33
47a7aee Fix hyperlinks for dependent tickets (#7139, #4976).
diff --git a/mastertickets/web_ui.py b/mastertickets/web_ui.py
index a91b862..698ed98 100644
--- a/mastertickets/web_ui.py
+++ b/mastertickets/web_ui.py
@@ -32,7 +32,7 @@ class MasterTicketsModule(Component):
      use_gs = BoolOption('mastertickets', 'use_gs', default=False,
                          doc='If enabled, use ghostscript to produce 
nicer output.')

-    FIELD_XPATH = 
'div[@id="ticket"]/table[@class="properties"]/td[@headers="h_%s"]/text()'
+    FIELD_XPATH = 
'.//div[@id="ticket"]/table[@class="properties"]//td[@headers="h_%s"]/text()'
      fields = set(['blocking', 'blockedby'])

      # IRequestFilter methods
===

It appears as though the new functionality always puts out a "medium" 
verbosity diff. Though the manpage says that it honors pretty=oneline, 
it does not seem to.

I searched around the message logs, etc. and would have expected this 
change to have thrown everyone else into as much upheaval as it has in 
my organization, and found nothing. Am I missing something?

Thanks in advance.
-- 
Matthew Caron, Software Build Engineer
Sixnet, a Red Lion business | www.sixnet.com
+1 (518) 877-5173 x138 office
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help