Re: [PATCH v7 02/16] Add git-remote-testsvn to Makefile
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:35
Florian Achleitner [off-list ref] writes:
quoted hunk
The link-rule is a copy of the standard git$X rule but adds VCSSVN_LIB. Signed-off-by: Florian Achleitner <redacted> Signed-off-by: Junio C Hamano <redacted> --- Makefile | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/Makefile b/Makefile index 66e8216..1b09454 100644 --- a/Makefile +++ b/Makefile@@ -477,6 +477,7 @@ PROGRAM_OBJS += sh-i18n--envsubst.o PROGRAM_OBJS += shell.o PROGRAM_OBJS += show-index.o PROGRAM_OBJS += upload-pack.o +PROGRAM_OBJS += remote-testsvn.o # Binary suffix, set to .exe for Windows builds X =@@ -2352,6 +2353,10 @@ git-http-push$X: revision.o http.o http-push.o GIT-LDFLAGS $(GITLIBS) $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \ $(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT) +git-remote-testsvn$X: remote-testsvn.o GIT-LDFLAGS $(GITLIBS) $(VCSSVN_LIB) + $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIBS) \ + $(VCSSVN_LIB) + $(REMOTE_CURL_ALIASES): $(REMOTE_CURL_PRIMARY) $(QUIET_LNCP)$(RM) $@ && \ ln $< $@ 2>/dev/null || \
I'd squash in a change to add this executable to .gitignore (attached) to this patch. Unless you have objections to it, or suggestions to do it better, there is no need to resend. Thanks. .gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git i/.gitignore w/.gitignore
index bb5c91e..51294d6 100644
--- i/.gitignore
+++ w/.gitignore@@ -125,6 +125,7 @@ /git-remote-fd /git-remote-ext /git-remote-testgit +/git-remote-testsvn /git-repack /git-replace /git-repo-config