Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:33
Possibly related (same subject, not in this thread)
- 2016-06-15 · RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0 · Joachim Schmitz <hidden>
- 2016-06-15 · Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0 · Junio C Hamano <hidden>
- 2016-06-15 · RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0 · Joachim Schmitz <hidden>
- 2016-06-15 · Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0 · Junio C Hamano <hidden>
- 2016-06-15 · RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0 · Joachim Schmitz <hidden>
"Joachim Schmitz" [off-list ref] writes:
Signed-off-by: Joachim Schmitz <redacted>
At the very least, please mention that this reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of libcURL.
quoted hunk
--- http.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/http.c b/http.c index b61ac85..18bc6bf 100644 --- a/http.c +++ b/http.c@@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,int target, int options) ret = HTTP_REAUTH; } } else { +#if LIBCURL_VERSION_NUM >= 0x070c00 if (!curl_errorstr[0]) strlcpy(curl_errorstr, curl_easy_strerror(results.curl_result), sizeof(curl_errorstr)); +#endif ret = HTTP_ERROR; } } else { -- 1.7.12 Bye, Jojo