Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:32

Florian Achleitner [off-list ref] writes:
On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
quoted
Junio C Hamano [off-list ref] writes:
quoted
I think you meant something like:

      init_notes(NULL, notes_ref, NULL, 0);

        marksfile = fopen(marksfilename, "r");
        if (!marksfile) {
              regenerate_marks(marksfilename);
                marksfile = fopen(marksfilename, "r");
Btw, this is FILE* is nowhere closed in your fixuped version in fa/remote-svn.
Please fix up things like that in your reroll.  I was doing minimum
fixes I noticed to get it compile before pushing it out as part of
'pu' (the alternative was simply not to merge and discard the
topic).

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help