Re: [PATCH v2 resend] gitk: Use an external icon file on Windows
From: Sebastian Schuberth <hidden>
Date: 2016-06-15 22:54:27
On Wed, Aug 8, 2012 at 11:13 PM, Junio C Hamano [off-list ref] wrote:
Forwarding a misdirected patch to the maintainer who is free to pick or ignore.
How am I supposed to know if a patch has been ignored as an oversight (in which case I would resend), or because the maintainer decided not to include it (in which case I would not resend in order to not annoy the maintainer)?
Personally I am negative on it (nobody on the list asked for the "new" Git icon as far as I recall), but my voice on this counts just as little as others.
I guess most patches on the list come in unasked, so I cannot follow your negative attitude because of this. Also, the patch does not enforce the new icon on any platform. From a user's perspective, [1] as mentioned on [2] is the official Git homepage, thus the icon used on the homepage can be regarded as the official Git icon. In Git for Windows, we try to have a consistent user experience, and we had a report about gitk still using the "old" icon [3]. This patch fixes that, and I'm sending it upstream in an effort to not let msysgit's fork of git diverge too much from upstream. [1] http://git-scm.com/ [2] http://en.wikipedia.org/wiki/Git_%28software%29#External_links [3] https://github.com/msysgit/msysgit/issues/44 -- Sebastian Schuberth