Re: [PATCH 2/2] prune.c: only print informational message in show_only or verbose mode

Brandon Casey [off-list ref] writes:

On Mon, Aug 6, 2012 at 11:03 PM, Jeff King [off-list ref] wrote:

quoted

On Mon, Aug 06, 2012 at 10:44:07PM -0700, Brandon Casey wrote:

quoted

Anyone else? :)

Sorry to gang up on you. :)

Heh. :b

quoted

I still think your 2/2 is worth doing independently, though. It is silly
that git-prune will not mention pruned objects without "-v", but will
mention temporary files. They should be in the same category.

As I mentioned in an earlier message, I think the original thinking
was that removing a temporary object should be an unusual occurrence
that indicates a failure of some sort, so you want to inform the user
who may want to investigate (of course the file's gone, so what's to
investigate).  Removing a stale object file on the other hand is just
part of the normal operation.  That is why the former is always
printed out and the latter only when -v is used.

That matches my understanding, modulo "may want to investigate" is
probably more like "may want to be reminded of an earlier repack
that was aborted".

That was the original thinking, but I don't think it matters very
much.  Printing both using the same conditions seems valid.

Yeah, I agree that it does not make much difference either way and
both ways of thinking feel equally valid.