Re: [PATCH] Enable HAVE_DEV_TTY for Solaris
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:26
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] Enable HAVE_DEV_TTY for Solaris · Ben Walton <hidden>
Ben Walton [off-list ref] writes:
Now that git_terminal_prompt can cleanly interact with /dev/tty on Solaris, enable HAVE_DEV_TTY so that this code path is used for credential reading instead of relying on the crippled getpass(). Signed-off-by: Ben Walton <redacted> --- This is a follow up to Jeff's patch that fixes git_terminal_prompt on Solaris. I don't have 5.6 or 5.7 for testing but I believe this should be valid for both of those releases as well.
So which direction do you guys want to go? Use the "bidirectional stdio with fseek()" for now, with the expectation that Tay's other series will rewrite it to fd based one?
quoted hunk
Makefile | 1 + 1 file changed, 1 insertion(+)diff --git a/Makefile b/Makefile index 15d1319..6b0c961 100644 --- a/Makefile +++ b/Makefile@@ -1014,6 +1014,7 @@ ifeq ($(uname_S),SunOS) NO_REGEX = YesPlease NO_FNMATCH_CASEFOLD = YesPlease NO_MSGFMT_EXTENDED_OPTIONS = YesPlease + HAVE_DEV_TTY = YesPlease ifeq ($(uname_R),5.6) SOCKLEN_T = int NO_HSTRERROR = YesPlease