Fwd: [PATCH] Improve tests for detached worktree in git-submodule

Forwardning for the record as vger rejected my previous HTML email.

---------- Forwarded message ----------
From: Daniel Graña <redacted>
Date: Mon, Jul 30, 2012 at 2:04 PM
Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule
To: Jeff King <redacted>
Cc: Junio C Hamano <redacted>, git@vger.kernel.org


Hi Jeff,

I understand your complain and I must apologize for confusing you with Jens
from this thread
http://thread.gmane.org/gmane.comp.version-control.git/201851

This patch is a follow up to that thread (that I fail to include as
reply-to) and tries to address the issues noted by Junio and Jens there.



On Mon, Jul 30, 2012 at 1:39 PM, Jeff King [off-list ref] wrote:

On Mon, Jul 30, 2012 at 01:10:10PM -0300, Daniel Graña wrote:

quoted

Subject: Re: [PATCH] Improve tests for detached worktree in
git-submodule

Signed-off-by: Daniel Graña <redacted>

The space between the subject and your S-o-b is an excellent place to
explain the rationale for your commit.

How are we improving them? What cases or classes of failure does this
catch that the original did not?  It may be because I have not been
following this topic closely, but reading the patch, I am not sure what
the purpose is. Please make life easier for reviewers by telling us what
to expect and why before we even get to the patch.

-Peff