Re: [PATCH 2/4] Prepare Git::SVN for extraction into its own file.

Junio C Hamano [off-list ref] writes:

"Michael G. Schwern" [off-list ref] writes:

quoted

From: "Michael G. Schwern" <redacted>

This means it should be able to load without git-svn being loaded.

* Load Git.pm on its own and all the needed command functions.

* It needs to grab at a git-svn lexical $_prefix representing the --prefix
  option.  Provide opt_prefix() for that.  This is a refactoring artifact.
  The prefix should really be passed into Git::SVN->new.

I agree that the prefix is part of SVN->new arguments in the final

s/is/should be/; sorry for the noise.

state after applying the whole series (not just these four but also
with the follow-up patches).
...
Again, I agree with you that passing $prefix as one of the arguments
to ->new is the right thing to do in the final state after applying
the whole series.  I don't know if later steps in your patch series
will do so, but it _might_ make more sense to update ->new and its
callers to do so without doing anything else first, so that you do
not have to call out to the ::opt_prefix() when you split things
out.