Re: [PATCH v3 6/7] Remove unused and bad gettext block from git-am

Martin von Zweigbergk [off-list ref] writes:

On Tue, Jul 24, 2012 at 11:27 AM, Jonathan Nieder [off-list ref] wrote:

quoted

Hi,

Jiang Xin wrote:

quoted

Gettext message should not start with '-' nor '--'. Since the '-d' and
'--dotest' options do not exist in OPTIONS_SPEC variable, it's safe to
remove the block.

The above justification is not a sufficient reason to stop giving
helpful advice when someone uses an option that was historically
supported:

I think Jiang is saying that "git am --dotest=..." already errors out
because "dotest" is not in the OPTIONS_SPEC. See 98ef23b (git-am:
minor cleanups, 2009-01-28). Or am I missing something?

No you are not missing anything, I would think.