Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned

On Mon, Jul 23, 2012 at 01:49:55PM -0700, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

If we launch an editor for the user to create a commit
message, they may put significant work into doing so.
Typically we try to check common mistakes that could cause
the commit to fail early, so that we die before the user
goes to the trouble.

We may still experience some errors afterwards, though; in
this case, the user is given no hint that their commit
message has been saved. Let's tell them where it is.

Liberal use of atexit() for something like this makes me cringe
somewhat.

I don't like it either, but there's not really a better way. The die()
that Ramana triggered in the initial report is deep inside the ident
code. The only other option would be to hook into die_routine, which I
think is even uglier.

-Peff