Re: [PATCH/RFC] git-svn: don't create master if another head exists

On Wed, Jul 18, 2012 at 11:27:22AM +0000, Eric Wong wrote:

Marcin Owsiany [off-list ref] wrote:

quoted

On Wed, Jul 11, 2012 at 03:56:43PM -0700, Junio C Hamano wrote:

quoted

If the caller does not handle errors, it could be even clearer to
write it like

	command_noisy(qw(update-ref HEAD), $gs->refname) ||
		die "Cannot update HEAD!!!";

Turns out that command_noisy()
 - has a meaningless return value
 - throws an exception on command failure
so the "||" bit does not work.
Also, for some reason command_noisy does not check for the command being
killed by a signal, so I'd prefer to leave the verify_ref there.

Ugh, I always forget the Git.pm API, too.  Perhaps command_noisy should
be made to respect signals in exit codes (the rest of git-svn is
compromised by this behavior in command_noisy, too, it turns out... :x)

I'm not sure what else would break if command_noisy were changed,
git-svn appears to be the only user in git.git.

Other "command" flavours should probably also be changed to match?

-- 
Marcin Owsiany [off-list ref]              http://marcin.owsiany.pl/
GnuPG: 2048R/02F946FC  35E9 1344 9F77 5F43 13DD  6423 DBF4 80C6 02F9 46FC

"Every program in development at MIT expands until it can read mail."
                                                              -- Unknown