Re: [PATCH] config: fix several access(NULL) calls
From: Matthieu Moy <hidden>
Date: 2016-06-15 22:54:15
Jeff King [off-list ref] writes:
On Fri, Jul 13, 2012 at 10:48:18AM +0200, Matthieu Moy wrote:quoted
Junio C Hamano [off-list ref] writes:quoted
But is it really true that we want to error out on missing HOME if we have usable XDG stuff?Anyone else have an opinion on this? In short, the question is whether export XDG_CONFIG_HOME=some-existing-dir unset HOME git config foo.baz boz should die("$HOME is unset") or use the XDG config file.What did previous versions of git do? From my reading of 21cf32279, the previous behavior was that if $HOME was not set, git would silently avoid reading from $HOME/.gitconfig entirely.
Yes, and this is still the case for _reading_. But the current case is about deciding which file to use when _writing_. Git was already dying when writing with an unset $HOME. There is no behavior change in this case. With Junio's suggestion, we would have a behavior change in that we would write to the XDG file if we can find it (using XDG_CONFIG_HOME, obviously, since $HOME is unset in this case). -- Matthieu Moy http://www-verimag.imag.fr/~moy/