[PATCH 08/12] git-remote-mediawiki: change return type of get_mw_pages
From: Matthieu Moy <hidden>
Date: 2016-06-15 22:54:13
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH 08/12] git-remote-mediawiki: change return type of get_mw_pages · Matthieu Moy <hidden>
- 2016-06-15 · Re: [PATCH 08/12] git-remote-mediawiki: change return type of get_mw_pages · Junio C Hamano <hidden>
The previous version was returning the list of pages to be fetched, but we are going to need an efficient membership test (i.e. is the page $title tracked), hence exposing a hash will be more convenient. Signed-off-by: Matthieu Moy <redacted> --- contrib/mw-to-git/git-remote-mediawiki | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki
index 063a978..4bf990b 100755
--- a/contrib/mw-to-git/git-remote-mediawiki
+++ b/contrib/mw-to-git/git-remote-mediawiki@@ -379,7 +379,7 @@ sub get_mw_pages { get_all_mediafiles(\%pages); } } - return values(%pages); + return %pages; } # usage: $out = run_git("command args");
@@ -536,7 +536,8 @@ my %basetimestamps; sub get_last_remote_revision { mw_connect_maybe(); - my @pages = get_mw_pages(); + my %pages_hash = get_mw_pages(); + my @pages = values(%pages_hash); my $max_rev_num = 0;
@@ -802,7 +803,8 @@ sub mw_import_ref { mw_connect_maybe(); - my @pages = get_mw_pages(); + my %pages_hash = get_mw_pages(); + my @pages = values(%pages_hash); print STDERR "Searching revisions...\n"; my $last_local = get_last_local_revision();
--
1.7.11.1.147.g47a574d