Re: bug: "fatal: cannot pread pack file", version 1.7.5.4

Andreas Schwab [off-list ref] writes:

Jeff King [off-list ref] writes:

quoted

It's very odd for pread to report ENOENT (since it is always operating
on an already-opened file descriptor).

It doesn't, but gettext will clobber errno:

		n = pread(pack_fd, inbuf, n, from);
		if (n < 0)
			die_errno(_("cannot pread pack file"));

There is nothing that saves errno.  This isn't limited to i18n though,
any function call in the arguments may potentially clobber errno.

Argh...