Re: [PATCHv3 01/11] Makefile: sort LIB_H list
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:09
Jeff King [off-list ref] writes:
This was mostly sorted already, but put things like "cache-tree.h" after "cache.h", even though "-" comes before "." (at least in the C locale). This will make it easier to keep the list sorted later by piping it through "sort".
I agree this would make it easier to blindly run "sort", but I think the result hurts scannability. Is it a good change?
quoted hunk
Signed-off-by: Jeff King <redacted> --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/Makefile b/Makefile index 62de0b4..72cdb56 100644 --- a/Makefile +++ b/Makefile@@ -595,8 +595,8 @@ LIB_H += attr.h LIB_H += blob.h LIB_H += builtin.h LIB_H += bulk-checkin.h -LIB_H += cache.h LIB_H += cache-tree.h +LIB_H += cache.h LIB_H += color.h LIB_H += commit.h LIB_H += compat/bswap.h@@ -636,13 +636,13 @@ LIB_H += mailmap.h LIB_H += merge-file.h LIB_H += merge-recursive.h LIB_H += mergesort.h -LIB_H += notes.h LIB_H += notes-cache.h LIB_H += notes-merge.h +LIB_H += notes.h LIB_H += object.h -LIB_H += pack.h LIB_H += pack-refs.h LIB_H += pack-revindex.h +LIB_H += pack.h LIB_H += parse-options.h LIB_H += patch-ids.h LIB_H += pkt-line.h@@ -668,8 +668,8 @@ LIB_H += submodule.h LIB_H += tag.h LIB_H += thread-utils.h LIB_H += transport.h -LIB_H += tree.h LIB_H += tree-walk.h +LIB_H += tree.h LIB_H += unpack-trees.h LIB_H += userdiff.h LIB_H += utf8.h