Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 0/9] Extending the shelf life of "git describe" output

From: Thomas Rast <hidden>
Date: 2016-06-15 22:54:08

Junio C Hamano [off-list ref] writes:
Thomas Rast [off-list ref] writes:
quoted
Two random thoughts:

* The commit_only flag is only one thing you may "know" about the
  parsing, as you state above.  E.g., we may know the distance from a
  certain tag.  Given this, wouldn't it be cleaner to patch a struct
  things_we_know into the call chain instead of only a flag?

* The treeish:path syntax also "knows" that the left side must be or
  peel to a tree, so it makes no sense to go looking for a blob.
Both good.  I take it to mean that we found a volunteer to take the
ownership of the second idea to build on top of the series ;-)
Does the idea come with round tuits included? :-)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help