Re: [PATCH 1/2] Documentation: --no-walk is no-op if range is specified
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:07
Carlos Martín Nieto [off-list ref] writes:
quoted hunk
The existing description can be misleading and cause the reader to think that --no-walk will do something if they specify a range in the command line instead of a set of revs. Signed-off-by: Carlos Martín Nieto <redacted> --- Documentation/rev-list-options.txt | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt index 1ae3c89..84e34b1 100644 --- a/Documentation/rev-list-options.txt +++ b/Documentation/rev-list-options.txt@@ -622,6 +622,7 @@ These options are mostly targeted for packing of git repositories. --no-walk:: Only show the given revs, but do not traverse their ancestors. + This has no effect if a range is specified. --do-walk::
This is correct as a description of the current behaviour, but I have to wonder if we should error out when the user explicitly (i.e. the implicit uses of --no-walk by "show" and "cherry-pick" need to be treated differently) gives --no-walk and a negative commit (either by A..B range, or a separate ^A). Would that break a valid script, and if not, how involved would such a fix be?