Re: [PATCHv6 1/4] Read (but not write) from $XDG_CONFIG_HOME/git/config file

Junio C Hamano [off-list ref] a écrit :

Erik Faye-Lund [off-list ref] writes:

quoted

The awkward thing about doing this, is that the memory allocated by
the strbuf cannot be reclaimed if you go with this. A pointer that has
been adjusted (like cleanup_path can do) cannot be successfully fed to
free.

Yeah, I wouldn't recommend doing that.  Either

	path = strbuf_detach(&sb, NULL);
	retval = xstrdup(cleanup_path(path));
        free(path);
        return retval;

or

	path = xstrdup(cleanup_path(sb.buf));
        strbuf_release(&sb);
        return path;

would be more sensible.

Erik, what do you prefer ? You can have the final answer.