Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH_v1] add 'git credential' plumbing command

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:02

Jonathan Nieder [off-list ref] writes:
Jonathan Nieder wrote:
quoted
Matthieu Moy wrote:
quoted
Junio C Hamano [off-list ref] writes:
quoted
quoted
quoted
Does "git credential" need to have a git repository (i.e. run in a
git repository or in a working tree that is controlled by one)?
It shouldn't (hence, should use RUN_SETUP_GENTLY).
Rather, that means it should use 0:

			{ "credential", cmd_credential },
... and it turns out I'm talking nonsense.  RUN_SETUP_GENTLY would
be a sensible choice indeed, to allow the command to discover the
current repository and read .git/config from there indeed.
Yeah, I think "it is OK to be called outside a repository, but if
inside we read and honor the configuration" is a sensible behaviour
for this command.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help