Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCHv2] Warnings before rebasing -i published history

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:54:02

konglu@minatec.inpg.fr writes:
Matthieu Moy [off-list ref] a écrit :
quoted
Lucien Kong [off-list ref] writes:
quoted
"git rebase -i" can be very dangerous if used on an already published
history. This code detects that one is rewriting a commit that is an
ancestor of a remote-tracking branch, and warns the user through the
editor. This feature is controlled by a new config key
rebase.checkremoterefs.
For the lazy, you could provide an example of result in the commit
message. People don't want to review how the patch is written if they
disagree with the result.
Right, but wouldn't it be better to put the example in the doc
git-rebase.txt ?
Why not. In any case, it should be easy to find for reviewers (I had to
dig a little to find the expected value in the tests).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help