Re: [PATCHv6 4/4] Write to $XDG_CONFIG_HOME/git/config file
From: David Aguilar <hidden>
Date: 2016-06-15 22:54:01
On Fri, Jun 8, 2012 at 11:19 PM, Junio C Hamano [off-list ref] wrote:
David Aguilar [off-list ref] writes:quoted
I'm all for this change too.Do you mean just the general direction, or including the implementation?
General direction, including the backwards-compatibility concerns described in the commit message.
quoted
I did a little research RE: the OSX and Windows question. glib makes no differentiation between OSX and Linux, but Windows does have its own #ifdef. http://git.gnome.org/browse/glib/tree/glib/gutils.c#n1251 I certainly don't think this should affect this series, I'm just noting it as something that the Windows folks might care about. Perhaps something for compat/ in the future? The downside to doing the same as glib is more documentation. The upside is... consistency?Probably. I think we should follow whatever existing and prevalent practice is, and my gut feeling is that we would end up first doing POSIX only thing in my tree, and msysgit folks will quickly feed me updates to tweak the behaviour to match what of Windows version.
That sounds good to me. Thanks, -- David