Re: rebase [-i --exec | -ix] <CMD>...

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: rebase [-i --exec | -ix] <CMD>...

From: Andreas Schwab <hidden>
Date: 2016-06-15 22:54:00

konglu@minatec.inpg.fr writes:
As you pointed out, the problem seems to come from this line
	tmp=$(sed "/^pick .*/i\exec $i" "$1")
I think that the dquote here doesn't work on MacOS, though i've
never tried it. Anyway, even if it's not the problem, this kind
of quoting is quite odd so it will be removed in the next patch
(I do not see other reasons of the issue, as sed's i command should
work on MacOS).
You need to put a newline after the backslash.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: rebase [-i --exec | -ix] <CMD>...

From: <hidden>
Date: 2016-06-15 22:54:00

Andreas Schwab [off-list ref] a écrit :
konglu@minatec.inpg.fr writes:
quoted
As you pointed out, the problem seems to come from this line
	tmp=$(sed "/^pick .*/i\exec $i" "$1")
I think that the dquote here doesn't work on MacOS, though i've
never tried it. Anyway, even if it's not the problem, this kind
of quoting is quite odd so it will be removed in the next patch
(I do not see other reasons of the issue, as sed's i command should
work on MacOS).
You need to put a newline after the backslash.
That's what we originally did. Though we did it with indentations:
         tmp=$(sed "/^pick .*/i\
                            exec $i" "$1")
Should it be put that way (without indentations) ?
         tmp=$(sed "/^pick .*/i\
exec $i" "$1")

Thanks,

Lucien Kong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help