Thread (1 message) 1 message, 1 author, 2016-06-15

Re: Please revert e371046b6473907aa6d62b7862a3afe9d33561e1

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:00

John Wiegley [off-list ref] writes:
I've spoken to the author of this commit, Matthias Urlichs.  Here is an
excerpt of our conversation:
quoted
On Sat, 2012-04-21 at 00:08 -0500, John Wiegley wrote:
quoted
Just wanted to let you know that this bit me.  I have a client whose CVS
repository I'm converting to Git, and they have _many_ log messages that
are larger than 32k in size.
Feel free to submit a patch that reverts this. These days, there's probably
no user of cvs2git left, but at that time it was important to get the same
commit IDs back.
This just needs to be reverted:

    git revert e371046b6473907aa6d62b7862a3afe9d33561e1
That ancient commit does two things, and one thing that it claims to
do does not have anything to do with 32k limit.

Please send in a patch that exactly addresses the issue (it is
unclear if you want to keep or drop the removal of trailing
whitespaces that is done by that commit).  The proposed log message
needs to justify why breaking other people's repositories that were
converted by an ancient version of cvs2git is lessor of two evils
(the other one being logs longer than 32k are not kept for you).

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help