Re: [PATCH 1/2] git-svn: use platform specific auth providers

Matthijs Kooijman [off-list ref] writes:

It seems this is indeed the case. I can't remember what I based the
1.6.12 on, but looking at the svn changelog [1], the first working version
is 1.6.15:

    Version 1.6.15
    [...]
       * improve some swig parameter mapping (r984565, r1035745)

[1]: http://svn.apache.org/repos/asf/subversion/trunk/CHANGES

Gr.

Thanks.  I find that "improve some mapping" is a bit too subtle way
to say "we are fixing a bug that can lead to a segfault" to my
taste, though ;-)

Eric, I can directly queue this as a regression fix in my tree, you
can eyeball and give your blessing (or "No, that is wrong--here is
the right version" is even better), or you can queue it and tell me
to pull from you.  How do we want to proceed?

-- >8 --
Subject: [PATCH] git-svn: platform auth providers are working only on 1.6.15
 or newer

Matthijs Kooijman reports that the cut-off point 082afee (git-svn:
use platform specific auth providers, 2012-04-26) set at 1.6.12 to
use this feature safely was incorrect, and it is 1.6.15 instead:

    http://svn.apache.org/repos/asf/subversion/trunk/CHANGES
    Version 1.6.15
       * improve some swig parameter mapping (r984565, r1035745)

Signed-off-by: Junio C Hamano <redacted>
---
 git-svn.perl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-svn.perl b/git-svn.perl
index 1a17f94..abbd6b8 100755
--- a/git-svn.perl
+++ b/git-svn.perl

@@ -5481,7 +5481,7 @@ ()
 
 	# earlier 1.6.x versions would segfault, and <= 1.5.x didn't have
 	# this function
-	if (::compare_svn_version('1.6.12') > 0) {
+	if (::compare_svn_version('1.6.15') >= 0) {
 		my $config = SVN::Core::config_get_config($config_dir);
 		my ($p, @a);
 		# config_get_config returns all config files from

-- 
1.7.11.rc1.2.g33fe195