Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCHv4] Read (but not write) from XDG configuration, XDG attributes and XDG ignore files

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:59

Ramsay Jones [off-list ref] writes:
Subject: [PATCH] path.c: Fix a static buffer overwrite bug by avoiding mkpath()

In order to fix the bug, we introduce a new variation of the mkpath()
function, mkpathdup(), which avoids the use of the internal static
buffers.
Shouldn't we aim a bit higher to also avoid the use of bounded
buffer?  Instead of returning bad_path, retry with lengthened buffer
until we succeed, or something.

Better yet, internally use strbuf_vaddf().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help