Thread (15 messages) 15 messages, 3 authors, 2016-06-15

Re: [PATCH 2/6] reflog: remove i18n legos in pruning message

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:53:57

On Thu, May 31, 2012 at 8:45 PM, Jonathan Nieder [off-list ref] wrote:
Thanks.  Style: how about

       if (!cb->newlog)
               printf("would prune %s", message);
       else if (cb->cmd->verbose)
               printf("prune %s", message);

?  I think that would be more readable than the lego original.
thanks
BTW I'm not sure if this message would be a good candidate for
translation.  Especially in the --dry-run case, it feels like output
that is intended to be simple enough for scripts to parse.  (Though on
the other hand, I don't know of any scripts or use cases that actually
parse it, so maybe nobody would mind.)
it's gray area. reflog is not categorized as plumbing. Maybe adding
--plumbing for scripts?
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help