Thread (1 message) 1 message, 1 author, 2016-06-15

Re: Bug: rebase when an author uses accents in name on MacOSx

From: Thomas Rast <hidden>
Date: 2016-06-15 22:53:57

Jeff King [off-list ref] writes:
On Wed, May 30, 2012 at 04:45:33PM -0700, Junio C Hamano wrote:
quoted
Lanny Ripple [off-list ref] writes:
quoted
  lanny;~> echo "Rémi Leblond" | LANG=C LC_ALL=C sed -ne 's/.*/GIT_AUTHOR_NAME='\''&'\''/p'
  GIT_AUTHOR_NAME='R'émi Leblond
So in C locale where each byte is supposed to be a single character,
that implementation of "sed" refuses to match a byte with high-bit
set when given a pattern '.'?

That is a surprising breakage, I would have to say.
It should not be too surprising, since we discussed it a few months ago:

  http://thread.gmane.org/gmane.comp.version-control.git/192218

Thomas provided a gross but workable solution here:

  http://article.gmane.org/gmane.comp.version-control.git/192237

and we also talked about eventually having a shell-quoting mechanism for
pretty placeholders.  Then the discussion rambled into "this sed is
horribly broken, and the user should get a better sed" territory. Maybe
we need to revisit that decision, since this is now two bug reports.
Three actually, also counting Will Palmer (shruggar) who brought this up
on #git-devel shortly before the thread above.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help