Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 3/3] refs: use strings directly in find_containing_dir()

From: René Scharfe <hidden>
Date: 2016-06-15 22:53:53

Am 23.05.2012 00:18, schrieb Junio C Hamano:
René Scharfe[off-list ref]  writes:
quoted
What has git grep to do with refs?  It checks if the path in the command
above is a ref, which makes it iterate over all of them..
Do you mean:

	/* Is it a rev? */
         get_sha1()
         ->  ...
           ->  get_sha1_basic()
             ->  dwim_ref()

callpath?
Yes, indeed.  Hmm, this is done even if the paths come after a 
double-dash.  Anyway, I don't consider the check to be a performance 
issue, just a quick way to test the allocation count that i stumbled 
upon while working on the recent grep patches.

René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help